wp-webpack-script icon indicating copy to clipboard operation
wp-webpack-script copied to clipboard

Published 20 hours ago • verified publisher icon swashata

bannerConfig should not default if not filled, it should be left out

Open chrion02 opened this issue 3 years ago • 0 comments

The default bannerConfig should be left out in: https://github.com/swashata/wp-webpack-script/blob/77d9189fcac726e3adcd6129dd6079badc7486fc/packages/scripts/src/config/project.config.default.ts#L115-L130

Inlining css chunks is not pretty with a bannerConfig for each file. There is no need for a default config. Even bannerConfig: false does just return undefined for every property in: https://github.com/swashata/wp-webpack-script/blob/8d6be7522cbb1164d1446709e9c0c7cdd8b289fe/packages/scripts/src/config/WebpackConfigHelper.ts#L380-L402

chrion02 avatar Feb 14 '22 13:02 chrion02