swagger-codegen icon indicating copy to clipboard operation
swagger-codegen copied to clipboard
verified publisher icon swagger-api

[Python] Resolve ref object before other primitive types for model

Open zhengl7 opened this issue 8 years ago • 3 comments

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • [x] Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • [x] Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

@taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11)

Description of the PR

This change allows ref file to be named as primitive data types like array, and will be resolved correctly.

Fix #7030

zhengl7 avatar Nov 22 '17 22:11 zhengl7

The change looks good to me, but I wonder why nobody else replied here for 21 days? (I didn't because I was on vacation :)). I would wait for at least one more LGTM before merge this.

mbohlool avatar Dec 13 '17 23:12 mbohlool

LGTM

The message got lost in a mix of several other notifications I had while I was on vacation that week. Sorry about that.

kenjones-cisco avatar Dec 14 '17 00:12 kenjones-cisco

Hi, @taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11), sorry about the ping after long time, but is this good to be merged?

zhengl7 avatar May 15 '18 19:05 zhengl7