svelte icon indicating copy to clipboard operation
svelte copied to clipboard

feat: Little improvement to set_style()

Open adiguba opened this issue 1 year ago • 2 comments

Some little improvement to set_style() in order to avoid the check to style.getPropertyValue()

See issue https://github.com/sveltejs/svelte/issues/13791

Demo here : REPL

Before submitting the PR, please make sure you do the following

  • [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • [X] Prefix your PR title with feat:, fix:, chore:, or docs:.
  • [X] This message body should clearly illustrate what problems it solves.
  • [ ] Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • [X] Run the tests with pnpm test and lint the project with pnpm lint

adiguba avatar Oct 23 '24 17:10 adiguba

⚠️ No Changeset found

Latest commit: e577cdd0d03604e2aa66b24e48247a3b0c8e545d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Oct 23 '24 17:10 changeset-bot[bot]

You should also add __styles to the element_prototype in operations.js

trueadm avatar Oct 24 '24 12:10 trueadm

You should also add __styles to the element_prototype in operations.js

Done !

adiguba avatar Oct 24 '24 14:10 adiguba