language-tools icon indicating copy to clipboard operation
language-tools copied to clipboard

`$$Props` and missing children prop

Open dummdidumm opened this issue 2 years ago • 2 comments

Describe the bug

When using $$Props, children isn't likely set on it in Svelte libraries compiled with version 5. We need to add it in that case.

Reproduction

https://discord.com/channels/457912077277855764/1153350350158450758/1178260814239629353

Expected behaviour

No type error

System Info

  • OS: [e.g. Windows]
  • IDE: [e.g. VSCode, Atom]

Which package is the issue about?

svelte2tsx

Additional Information, eg. Screenshots

No response

dummdidumm avatar Nov 26 '23 09:11 dummdidumm

No such errors are displayed after downgrading svelte vscode extension to v108.0.0.

amit13k avatar Nov 26 '23 12:11 amit13k

Actually, the better fix is probably to adjust the typings in Svelte 5 to include children as a snippet prop on the attributes

dummdidumm avatar Nov 28 '23 09:11 dummdidumm