kit icon indicating copy to clipboard operation
kit copied to clipboard

[site] fix homepage dark mode strong text colour

Open teemingc opened this issue 2 years ago • 2 comments

The emphasised text "It's a love letter to web development" in the video section of the kit site home page has a poor contrast in dark mode. This removes the inline style color: --sk-theme-2; from that text to make it more visible.

Before: emphasised text has poor contrast in dark mode

After: emphasised text uses default dark mode text colour

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • [x] This message body should clearly illustrate what problems it solves.
  • [ ] Ideally, include a test that fails without this PR but passes with it.

Tests

  • [ ] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • [ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

teemingc avatar Dec 17 '22 04:12 teemingc

⚠️ No Changeset found

Latest commit: 43b65a8c0d7a8f2c69ab5bdcc2e53b55479ded65

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Dec 17 '22 04:12 changeset-bot[bot]

@s3812497 is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Dec 17 '22 04:12 vercel[bot]