kit icon indicating copy to clipboard operation
kit copied to clipboard

Grammar

Open yousufiqbal opened this issue 2 years ago • 2 comments

Should is better word here.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • [ ] This message body should clearly illustrate what problems it solves.
  • [ ] Ideally, include a test that fails without this PR but passes with it.

Tests

  • [ ] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • [ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

yousufiqbal avatar Dec 16 '22 05:12 yousufiqbal

⚠️ No Changeset found

Latest commit: 90aeb29fa2b294bc2a2b9361f0ddea68da9193f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Dec 16 '22 05:12 changeset-bot[bot]

@yousufiqbal is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Dec 16 '22 05:12 vercel[bot]

this is a very marginal PR. I think it was probably fine before. This is arguably an improvement, but it's not clear. I'll go ahead and merge this, but we really prefer PRs that are more substantial or fixing something that's more clearly wrong

benmccann avatar Dec 30 '22 05:12 benmccann