kit
kit copied to clipboard
chore: add ignore list to changesets config
uses a negated micromatch pattern to only include @sveltejs packages and published non-org packages.
This skips over the plethora of test apps and other non-published things like the templates.
Con: adding new non-org packages does require extending the negated pattern Pro: adding new test apps or other non-published packages does not require changes
As the second case is arguably happening more often and first publish of a new package is something we have to plan for either way, i prefer this approach over a positive pattern
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
- [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
- [ ] This message body should clearly illustrate what problems it solves.
- [ ] Ideally, include a test that fails without this PR but passes with it.
Tests
- [ ] Run the tests with
pnpm testand lint the project withpnpm lintandpnpm check
Changesets
- [ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running
pnpm changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0
⚠️ No Changeset found
Latest commit: c257e19387d3657bda024c76650644dbbfb6f62a
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@dominikg is attempting to deploy a commit to the Svelte Team on Vercel.
A member of the Team first needs to authorize it.
I think doing it in this direction is a good idea. We might someday add another non-org package, but I can't foresee any specific ones now.