kit
kit copied to clipboard
bump typescript
#7654. We also need to
- [ ] update the TS conversion for the docs to use
satisfies(in this PR, or in a follow-up?) - [ ] use
satisfiesin the template
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
- [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
- [x] This message body should clearly illustrate what problems it solves.
- [ ] Ideally, include a test that fails without this PR but passes with it.
Tests
- [ ] Run the tests with
pnpm testand lint the project withpnpm lintandpnpm check
Changesets
- [x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running
pnpm changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0
🦋 Changeset detected
Latest commit: d7c8a6f7086afc783473aa2484d8544ae7072d82
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| create-svelte | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Couple of blockers:
adapter-vercelno longer typechecks. wtf?- Sucrase, which we use to strip TypeScript out of the template source files, does not know how to deal with the
satisfiesoperator
I filed an issue in the sucrase repo: https://github.com/alangpierce/sucrase/issues/763. It's now been addressed
Re "use satisfies in the docs" - I would maybe wait 1-2 months before doing that, so people can familiarize themselves more with that. Also, VS Code is likely not on TS 4.9 yet so everyone not turning on "use TS workspace version" would see type errors and be confused.
Another blocker: prettier doesn't support that syntax yet. ESLint likely, too?
Aside: It would be great if this https://github.com/microsoft/TypeScript/issues/51086 was implemented, too - then JSDoc could also use that, and we don't need to create proxy types anymore for both JS/TS when people use it.
Bummer, function foo () {} satisfies Bar is invalid syntax, so we need to keep using const foo = (() => {}) satisfies Bar instead. Opened #51556
Prettier was updated in the 2.8 release (https://github.com/prettier/prettier/issues/13792), which master now uses
@typescript-eslint/parser was addressed in 5.45.0 (https://github.com/typescript-eslint/typescript-eslint/issues/5688). This repo doesn't use that project, but users are now unblocked
master is now using TypeScript 4.9, so most of this PR is obsolete. I'm going to close it in favor of https://github.com/sveltejs/kit/pull/7861, which extracts out the parts that haven't already been committed to master