kit icon indicating copy to clipboard operation
kit copied to clipboard

Add variables that contain URls

Open KevsRepos opened this issue 3 years ago • 4 comments

Describe the problem

When building your app, at some point you might wanna move a page to a different URL. But at that point you could already have dozens of links pointing to that page with the given static URL. Example: We have the Login Page in /Account/Login and we have set dozens of links all over the Webapp like that: <a href="/Account/Login">Login</a> Now, we want to move the Login page to this URL: /Account/User/Login. Now its a mess, all the links are broken and we have to fix em manually.

Describe the proposed solution

Add the feature to add a const that we can import from /Account/Login/+page.ts that contains the URL of that page. Yes, by moving the directory (and therefore the URL), the import wouldnt work anymore aswell. But vscode and other IDEs are fixing this issue already by automatically correcting the imports.

export const loginRoute = CURRENT.ROUTE;

Where CURRENT.ROUTE is determined during compile time, so its just like export const loginRoute = "/Account/Login" after the build completed.

Alternatives considered

The alternative is that we can manually make a mapping that we manually have to update...

Importance

would make my life easier

Additional Information

No response

KevsRepos avatar Oct 26 '22 15:10 KevsRepos

Sounds related to https://github.com/sveltejs/kit/issues/7110#issuecomment-1286611504 .

(in your specific case I think a simple string search + replace should do it?)

dummdidumm avatar Oct 26 '22 15:10 dummdidumm

Also sounds related to #6167.

I don't know what this current route string would be for routes with params in them.

Conduitry avatar Oct 27 '22 18:10 Conduitry

@KevsRepos I wonder if this could work for you?

// /Account/Login/+page.ts
import { page } from '$app/stores';

const loginRoute = $page.url.pathname;

david-plugge avatar Nov 03 '22 20:11 david-plugge

@david-plugge We dont need the current URI, we need every URI that exists in the whole app...

KevsRepos avatar Nov 04 '22 05:11 KevsRepos