kit
kit copied to clipboard
fix: deprecate cloudflare platform.context in favor for platform.ctx
Following #13851 I don't mind platform.context but it seems this is creating some inconsistency for people using create-cloudflare today. For the record, as far as I can remember, getPlatformProxy uses ctx, and in Cloudflare docs they use ctx as well.
Here are the places where platform.ctx typing is defined in create-cloudflare templates for Svelte:
- https://github.com/cloudflare/workers-sdk/blob/be766d267539b8f0a7ed6fc3dc979627f9eb7f04/packages/create-cloudflare/templates/svelte/workers/c3.ts#L79-L84
- https://github.com/cloudflare/workers-sdk/blob/be766d267539b8f0a7ed6fc3dc979627f9eb7f04/packages/create-cloudflare/templates/svelte/pages/c3.ts#L109-L114
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
- [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
- [x] This message body should clearly illustrate what problems it solves.
- [ ] Ideally, include a test that fails without this PR but passes with it.
Tests
- [x] Run the tests with
pnpm testand lint the project withpnpm lintandpnpm check
Changesets
- [x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.
Edits
- [x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.