kit
kit copied to clipboard
fix: use resolve_symlinks for node.universal and node.server
This PR seems to fix following issue with symbolic links in the routes https://github.com/sveltejs/kit/issues/8100
Minimal issue reproduction is available here: https://github.com/yukipastelcat/sveltekit-symlinks
Symbolic links in the reproduction repository will be created automatically during build, but my plugin is flaky, so you might need to run npm run build for the second time to reproduce the issue.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
- [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
- [x] This message body should clearly illustrate what problems it solves.
- [ ] Ideally, include a test that fails without this PR but passes with it.
Tests
- [x] Run the tests with
pnpm testand lint the project withpnpm lintandpnpm check
pnpm test command does not exist, so I ran pnpm test:kit instead, some tests are failing, but they also do it in the main branch.
Changesets
- [x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.
Edits
- [x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.
🦋 Changeset detected
Latest commit: 25df6ebc407b8315efc9f63fdfb2f761a0011bdc
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| @sveltejs/kit | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Thanks! The repro works well and I've tested the fix with it. Can you add a test for this? Maybe in one of the other test suite folders we could try to make it so the build fails? Otherwise, it looks good to me.