kit icon indicating copy to clipboard operation
kit copied to clipboard

feat: add option to configure rollup externals

Open jjjjw opened this issue 1 year ago • 1 comments

Add external as an option to the node-adapter. This allows the rollup externals to be configured if you have a use case where the default is not desirable.

jjjjw avatar Aug 26 '24 16:08 jjjjw

🦋 Changeset detected

Latest commit: 18a76de7d33daed8c7e0184b3d412639b259639a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-node Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Aug 26 '24 16:08 changeset-bot[bot]

What is a case where the default is undesireable? Can you give some examples / use cases?

dummdidumm avatar Jan 13 '25 19:01 dummdidumm

This was for packaging for AWS lambda. It was easier in that case to bundle all the dependencies.

I also wanted to use the build process to tree shake the dependencies to get the package size down.

jjjjw avatar Feb 02 '25 20:02 jjjjw

Ok seems like this won't be merged

jjjjw avatar Aug 12 '25 05:08 jjjjw