kit icon indicating copy to clipboard operation
kit copied to clipboard

fix: handle redirect thrown from root layout load when client-side navigating to a non-existent page

Open teemingc opened this issue 1 year ago • 1 comments

fixes https://github.com/sveltejs/kit/issues/11099

There is currently no client-side error handling logic for when we run the root layout load function from rendering the root error page. This catches and handles the unhandled thrown Redirect.

Note: we should be displaying a static fallback page for any other type of error but I'm not sure how to do that client-side (the function already exists but only for the server).


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • [x] This message body should clearly illustrate what problems it solves.
  • [x] Ideally, include a test that fails without this PR but passes with it.

Tests

  • [x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • [x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • [x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

teemingc avatar Mar 19 '24 17:03 teemingc

🦋 Changeset detected

Latest commit: bacbe5d971fe3b665327c503165c9cb3c54ba5af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Mar 19 '24 17:03 changeset-bot[bot]

preview: https://svelte-dev-git-preview-kit-12005-svelte.vercel.app/

this is an automated message

Rich-Harris avatar Jan 13 '25 12:01 Rich-Harris