kit icon indicating copy to clipboard operation
kit copied to clipboard

Published 20 hours ago • verified publisher icon sveltejs

feat: read assets inside an edge function

Open Rich-Harris opened this issue 1 year ago • 3 comments

resolves https://github.com/sveltejs/kit/issues/12446

just an experiment... wanted to see if we could implement read inside edge functions by just requesting them. might be useful in a pinch

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • [ ] This message body should clearly illustrate what problems it solves.
  • [ ] Ideally, include a test that fails without this PR but passes with it.

Tests

  • [ ] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • [ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • [ ] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Rich-Harris avatar Jan 19 '24 01:01 Rich-Harris

⚠️ No Changeset found

Latest commit: 325e7078fb50e106b325b06b58bae7ebd0466384

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jan 19 '24 01:01 changeset-bot[bot]

The "fetch to read asset" concept should also work for cloudflare pages I think

teemingc avatar Jan 19 '24 02:01 teemingc

Seems to be working quite nicely with @vercel/og on the edge https://svelte-og-image.vercel.app/

https://github.com/eltigerchino/svelte-og-image/blob/main/src/routes/og/%2Bserver.ts

The image below is rendered at the edge from https://svelte-og-image.vercel.app/og?title=Svelte%20OG%20Image

svelte og

teemingc avatar Jul 15 '24 16:07 teemingc