sveltesociety.dev icon indicating copy to clipboard operation
sveltesociety.dev copied to clipboard

Alternative solution for `components.json`, `templates.json` and `tools.json`.

Open ericfennis opened this issue 2 years ago • 2 comments
trafficstars

Why

I noticed there are a lot of PRs having merge conflicts because another PR is merged with changes in components.json, templates.json or tools.json. Resulting in asking the contributors every time to rebase their PR. This is not very efficient and maintaining this can be a pain.

Solution

Move each "repo" to its own JSON files.

To test this I started by moving the last added one to a JSON file. I think we could easily create a script for migrating all items in the JSON files to their own JSON files. But to make sure it is working with the current open PRs I kept the current JSON files for now.

Notes

The current updateStars.js is not working with this setup. I recommend removing this script and extending the "page load data" scripts I created for tools, templates, and components. We could fetch the GitHub stars there. So they will be updated every build. This will fixes #217

ericfennis avatar Mar 19 '23 20:03 ericfennis

Deploy Preview for sveltesociety-preview ready!

Name Link
Latest commit 794d96fc7a55220002010dc7c7c0f3c77e72d9e6
Latest deploy log https://app.netlify.com/sites/sveltesociety-preview/deploys/64176ac457bc75000873c975
Deploy Preview https://deploy-preview-393--sveltesociety-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Mar 19 '23 20:03 netlify[bot]

I added your idea to the discussion #318

MacFJA avatar Mar 20 '23 20:03 MacFJA

Closing this as we will be using a completely different system in the v2 version of the site.

kevmodrome avatar Aug 10 '24 21:08 kevmodrome