survey-creator icon indicating copy to clipboard operation
survey-creator copied to clipboard

chore: improve some typings

Open SamMousa opened this issue 1 year ago • 3 comments

SamMousa avatar Apr 18 '24 15:04 SamMousa

Can this be reviewed? Tests fail because they are brittle not because there's anything wrong with the code.

SamMousa avatar Apr 24 '24 08:04 SamMousa

Please check error logs. Linter checks are not passed:

D:\a\1\s\survey-creator\packages\survey-creator-core\src\property-grid\index.ts 673:29 error Expected a comma @typescript-eslint/member-delimiter-style 674:24 error Expected a comma @typescript-eslint/member-delimiter-style

D:\a\1\s\survey-creator\packages\survey-creator-core\src\property-grid\values.ts 22:28 error Expected a comma @typescript-eslint/member-delimiter-style

✖ 3 problems (3 errors, 0 warnings) 3 errors and 0 warnings potentially fixable with the --fix option.

tsv2013 avatar Apr 24 '24 08:04 tsv2013

Thanks for the feedback! I did actually (try to) interpret the logs, but honestly it's very unclear with the use of azure pipelines for anyone not familiar with them.

I've created #5434 to aid future contributors including myself.

SamMousa avatar Apr 24 '24 09:04 SamMousa