protocol-monorepo icon indicating copy to clipboard operation
protocol-monorepo copied to clipboard

[WORKFLOW] Subgraph deploy matrix

Open mmd-afegbua opened this issue 1 year ago • 2 comments

Sample run: https://github.com/superfluid-finance/protocol-monorepo/actions/runs/10305531612

mmd-afegbua avatar Aug 08 '24 14:08 mmd-afegbua

Changelog Reminder

Reminder to update the CHANGELOG.md for any of the modified packages in this PR.

  • [ ] CHANGELOG.md modified
  • [ ] Double check before merge

github-actions[bot] avatar Aug 08 '24 14:08 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.44%. Comparing base (349f760) to head (9fe607e). Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2003   +/-   ##
=======================================
  Coverage   88.44%   88.44%           
=======================================
  Files         111      111           
  Lines        6964     6969    +5     
  Branches      934      934           
=======================================
+ Hits         6159     6164    +5     
  Misses        803      803           
  Partials        2        2           
Flag Coverage Δ
ethereum-contracts 94.50% <ø> (ø)
sdk-core 88.44% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 08 '24 16:08 codecov[bot]

This moves logic from scripts (deploy.sh) to workflow files, specifically the list of networks per vendor. That violates the principle that workflows shall not contain more logic than necessary, such that they don't become the only way to execute tasks.

The logic introduced is the matrix for the list of network for each vendor, which had been previously handled by deploy.sh. deploy.sh can still execute the deployment task, just that if it is being used outside of the workflow, one is expected to know the vendor and networks that are supported there. This way, you dont't have to make changes to the deploy script if for instance, you want to experiment with a new network.

mmd-afegbua avatar Aug 21 '24 10:08 mmd-afegbua

@d10r

hellwolf avatar Aug 26 '24 09:08 hellwolf

We didn't manage to fix the failing test here, thus it's not required anymore (after consulting with @kasparkallas ).

Could be improved: when deploying to multiple networks, run only the deploy step for each.

d10r avatar Aug 27 '24 19:08 d10r

XKCD Comic Relif

Link: https://xkcd.com/2003 https://xkcd.com/2003

github-actions[bot] avatar Aug 28 '24 07:08 github-actions[bot]