Liav A.
Liav A.
> > which doesn't really support static compilation with it for many years (I do remember me trying to do static compile of something a few years ago and that...
> Static libc we "had" didn't even work, it just was there. Right. I "fondly" (actually really not) remember me trying to force the `BuggieBox` application to use static libc,...
I had to remove https://github.com/supercomputer7/serenity/commit/0bfc7b04119c7540d160050812694aa892791953 from this PR, as `aarch64` would not compile otherwise. I will see how to fix this in the big refactor PR, when we get there.
I rebased this and force-pushed to see if the CI flakiness is resolved.
Commit message nitpicks: `if DynamicLoader were invoked directly` => `if DynamicLoader was invoked directly` `it wasn't able to perform syscalls` => `it wouldn't be able to perform syscalls` `to crash...
> Seems like was/were after "if" somehow depends on the factuality of the clause (https://ell.stackexchange.com/a/127747), though I cannot decide whether "if DynamicLoader were invoked directly" is a fact or an...
> > Also, do you have an example of such program being run with /usr/lib/Loader.so? > > Yes! `cd /usr/Tests/LibELF; /usr/lib/Loader.so /usr/Tests/LibELF/TestDlOpen` crashes on master and works with this PR....
This looks mostly OK now, although I didn't test this. I'd suggest merging this and extensively testing this before making this device a default of some sort.
Here's a video demo to show the `WindowServer` support: https://github.com/SerenityOS/serenity/assets/51659396/6053cc28-cd81-475c-9274-02b4815887b4 I booted with PS/2 mouse being disabled, and added a USB mouse during the SerenityOS VM runtime. :)
I rebased this and force-pushed to see if the CI flakiness is resolved.