realtime-py icon indicating copy to clipboard operation
realtime-py copied to clipboard

fix: wildcard event is not handled correctly

Open orenwang opened this issue 3 years ago • 5 comments

Related: https://github.com/supabase-community/realtime-py/issues/32

orenwang avatar Feb 26 '22 02:02 orenwang

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 1.33%.

Quality metrics Before After Change
Complexity 4.00 ⭐ 4.38 ⭐ 0.38 👎
Method Length 34.91 ⭐ 35.91 ⭐ 1.00 👎
Working memory 5.90 ⭐ 6.13 ⭐ 0.23 👎
Quality 83.65% 82.32% -1.33% 👎
Other metrics Before After Change
Lines 130 132 2
Changed files Quality Before Quality After Quality Change
realtime/connection.py 83.65% ⭐ 82.32% ⭐ -1.33% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

sourcery-ai[bot] avatar Feb 26 '22 02:02 sourcery-ai[bot]

I don't if this PR is still valid, because I don't know why It hasn't been merged or at least reviewed

odiseo0 avatar Jun 27 '22 17:06 odiseo0

@odiseo0 Yeah... I figure the team has given up on the client for python.

orenwang avatar Jun 27 '22 23:06 orenwang

Hi! We haven't given up, it is just that we have prioritized postgrest, storage and gotrue since these are the most used clients, but we do want to pay attention to the realtime client as well. We'll try to be more active in this repo 🙂

dreinon avatar Jun 27 '22 23:06 dreinon

@dreinon That sounds great. And of course it makes sense to prioritize other repos!

orenwang avatar Jun 28 '22 00:06 orenwang