Xianda Sun

Results 87 comments of Xianda Sun

Oops, you're right. > we should probably document this? By using the `public` keyword, maybe we can say "this is not official yet"? ~~I am a little hesitate to add...

current concerns: * We need `recompute_logprob` for Gibbs sampling, the reason is: the values of the parameters on which a parameter block is conditioned will change in the general case...

Some new updates, based on an offline discussion with @yebai (edited Sep 17th) * `gibbs.jl` is moved into `/src` * it no longer uses `OrderedDict`, this is to keep the...

@torfjelde thanks for the very nice review. The code and markdown doc are out-of-sync, a major difference is the one in the markdown doc uses `OrderedDict`, but the one in...

@yebai @torfjelde this has been updated, many issues in the previous version has been corrected (thanks for the discussion and code review). I also added another notes in the folder...

In its current form, no interface change is made to AbstractMCMC, all the interface functions are from other packages.

the test error seems to be Julia 1.6-only related

related reply from @devmotion https://github.com/TuringLang/Turing.jl/pull/2304#issuecomment-2291097709

I don't understand why Document-CI is failing, `FLoop` is not in BangBang's [deps](https://github.com/JuliaFolds2/BangBang.jl/blob/master/Project.toml).

Okay, the situation is a bit troublesome. `BangBang` v0.4 moved to `Accesssors`, so all the `Setfield` related code are erroring out. Now, either we led some effort in backporting the...