sunkit-spex icon indicating copy to clipboard operation
sunkit-spex copied to clipboard

Xspec gain

Open KriSun95 opened this issue 1 year ago • 1 comments

PR Description

As described in #147 , this draft shows how the gain can be applied in sunkit-spex as it is applied in XSPEC. More discussion is needed but this should be somewhere to comment on.

We change the gain correction being applied to edit the photon axis grid of the SRM before the total count model calculation as opposed to the current behaviour where the gain is applied after the photon model is folded through the response.

KriSun95 avatar Jun 12 '24 20:06 KriSun95

Codecov Report

Attention: Patch coverage is 44.73684% with 21 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@eb860e9). Learn more about missing BASE report.

Files Patch % Lines
sunkit_spex/fitting_legacy/fitter.py 44.73% 21 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #148   +/-   ##
=======================================
  Coverage        ?   55.66%           
=======================================
  Files           ?       20           
  Lines           ?     3196           
  Branches        ?        0           
=======================================
  Hits            ?     1779           
  Misses          ?     1417           
  Partials        ?        0           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jun 12 '24 20:06 codecov-commenter