sunkit-image icon indicating copy to clipboard operation
sunkit-image copied to clipboard

Failing test `test_multiscale_gaussian`

Open nabobalis opened this issue 3 years ago • 5 comments

Describe the bug

test_multiscale_gaussian is failing sometimes on the CI.

I have been unable to replicate any of the fails locally using tox, changing Python version etc.

I have marked it as xfail for now but we need to debug this, see https://github.com/sunpy/sunkit-image/pull/95/

To Reproduce

I can't.

nabobalis avatar Sep 06 '22 14:09 nabobalis

Hello, Can I work on this?

meghana151 avatar Mar 08 '24 20:03 meghana151

Sure.

nabobalis avatar Mar 08 '24 20:03 nabobalis

I have tested by removing the @pytest.mark.xfail for the test_multiscale_gaussian with the python versions: 3.9, 3.10, 3.11 and their corresponding oldest dependencies too and all of them pass.

I believe that this issue can be safely closed.

Deus1704 avatar Mar 30 '24 13:03 Deus1704

Can you pull request the removal of the mark? Only if it passes on the ci, will we remove this

nabobalis avatar Mar 30 '24 15:03 nabobalis

sure!

Deus1704 avatar Mar 30 '24 15:03 Deus1704