sunkit-image icon indicating copy to clipboard operation
sunkit-image copied to clipboard

Published 20 hours ago • verified publisher icon sunpy

Generalize the RHE Function beyond AIA

Open GillySpace27 opened this issue 1 year ago • 4 comments

PR Description

GillySpace27 avatar Sep 22 '24 06:09 GillySpace27

This PR is associated with Issue #233 addressing the ability for the algorithm to operate on non-AIA datasets.

GillySpace27 avatar Sep 23 '24 17:09 GillySpace27

Thanks for the PR @GillySpace27, what other data have were you trying to run this on?

We will need to get some test data to confirm it works for non-AIA data.

nabobalis avatar Sep 23 '24 19:09 nabobalis

@nabobalis Thanks! The first non-AIA dataset I applied it to is some synthetic PUNCH test data. I'm interested in getting some others working too, including LASCO, SUVI, etc.

GillySpace27 avatar Sep 23 '24 20:09 GillySpace27

@nabobalis Thanks! The first non-AIA dataset I applied it to is some synthetic PUNCH test data. I'm interested in getting some others working too, including LASCO, SUVI, etc.

Is it possible we can add a file from the synthetic PUNCH test data to the repo?

nabobalis avatar Sep 23 '24 20:09 nabobalis

Thanks for the PR @GillySpace27, I noticed some effects due to upstream changes that I had to correct.

I also added some more changelogs due to the changes and some minor test fixes.

nabobalis avatar Oct 29 '24 22:10 nabobalis