Sunny Ripert comments

Results 92 comments of


                                            Sunny Ripert

changed to use button_to_add instead of link_to_add to make it more sema...

:+1:

Invoking undefined methods on a result does not raise errors

Perhaps to drop OpenStruct we can use either `method_missing` or define methods on the result set as it is being passed through.

Aliases for inputs and outputs

Do you have an example use-case for that? Could it be solved in plain Ruby by calling `alias description aliased_description`?

Aliases for inputs and outputs

I think this would require drastically changing how this is built, since now an organiser is not really involved in how children share tasks. Also `as:` isn’t very explicit in...

Aliases for inputs and outputs

Since the word “rename” implies “changing” the previous, maybe this should be a more generic name tied to the fact that we are copying or aliasing inputs. Perhaps prefixing it...

Aliases for inputs and outputs

@williampollet @AnneSottise: would the `play_input` syntax work for you, do you think?

Aliases for inputs and outputs

That looks fine to me. Would you care to build a PR for that feature? 🙏🏻

Aliases for inputs and outputs

@AnneSottise Yes you can open a PR directly to the repo from your fork, or you can share a link to a fork 🙏🏻

New notation for array inputs

That makes a lot of sense! I’d be happy to merge a PR for that 🙏🏻

New notation for array inputs

Actually, since now the array syntax for types is used as an "or": ```rb input :age, type: [Integer, Float] ``` I think it would make more sense to just keep...