Dan Gohman

Results 819 comments of Dan Gohman

> Is it possible to split the renaming of the math sources into a separate PR. Done, in #151. > Also, it looks like a lot of the Makefile refactoring...

The dependencies for this PR all landed, and this PR is now rebased, so it's now just changes to the top-level Makefile to support LTO, and ready for review!

@yamt I'm not actively working on this, so you are welcome to take this over!

https://github.com/CraneStation/wasi-libc/pull/154 is working on a CMake-based replacement for the current Makefile, which should address these issues.

Thanks for filing this! One question I have hear is, does Nix use this ability to have separate include and library directories to *version* them separately? Can users ask for...

Ah, yes, I forgot about that. Yes, there are a few, such as `EINVAL` and `EACCES`, which will be shared across eg. wasi-filesystem and an expected future wasi-sockets. One option...

wasi-libc includes codes from several external sources, with differing style conventions, so when adding new code, we generally just follow the style of the nearest code. That said, I agree...

It has always been envisioned that WASI would be adding sockets support at some point. And there is now a [wasi-sockets](https://github.com/WebAssembly/wasi-sockets/) proposal which is working towards adding it. A PR...

I can also add that some of the considerations have changed since this code was first developed. `__header_sys_socket.h` was written at a time when the WASI bindings did have a...

Yes, we could do something similar. The Emscripten version seems to have fewer special cases for performance, so it's likely a codesize versus speed tradeoff. We could let the user...