dominiontabs icon indicating copy to clipboard operation
dominiontabs copied to clipboard

Published 20 hours ago • verified publisher icon sumpfork

German translation for Seaside2nd edition and other small things

Open Xedorian opened this issue 3 years ago • 3 comments

Hey, I wanted to provide the German translation of Seaside 2nd edition, rule texts for some promo cards and update the German names of two cards but sadly don't have the necessary writing access. I did create a fork but couldn't get any further. Help would be appreciated with that. Thanks

Xedorian avatar Jul 19 '22 19:07 Xedorian

Hi, thanks for helping out! You would need to create a Pull Request from your fork to the repo.

sumpfork avatar Jul 19 '22 21:07 sumpfork

So I'm seemingly running into some problems but have no idea how I'm supposed to interpret their details (see my pull request). Sorry for the hassle. I would love to help but seemingly can't.

Xedorian avatar Jul 21 '22 18:07 Xedorian

The test is telling you that your JSON format is not valid: card_db_src/de/cards_de.json: Failed to json decode (Expecting ',' delimiter: line 2868 column 1 (char 451824)). I recommend producing the files locally (see https://github.com/sumpfork/dominiontabs#translations) so you can verify that things work as expected.

sumpfork avatar Jul 21 '22 18:07 sumpfork

This is deployed now, thanks!

sumpfork avatar Aug 15 '22 00:08 sumpfork