dominiontabs icon indicating copy to clipboard operation
dominiontabs copied to clipboard

Published 20 hours ago • verified publisher icon sumpfork

German Translation

Open ghost opened this issue 8 years ago • 10 comments

The Card text and the card names are not available in German. Instead, I get the english texts

ghost avatar Jul 22 '17 19:07 ghost

Correct. They need to be translated to German. See the file dominiontabs/domdiv/card_db/de/cards_de.json Any entry with "untranslated" needs a translation for the part listed. If you are able, we could use your help.

wvoigt avatar Jul 22 '17 22:07 wvoigt

#193

sumpfork avatar Feb 19 '18 22:02 sumpfork

#218 contributed a bunch more German translations, notably Nocture and Dark Ages.

sumpfork avatar Oct 10 '18 05:10 sumpfork

#233 added more

sumpfork avatar Nov 26 '18 17:11 sumpfork

I just noticed this issue, I wrote about polish translation here https://github.com/sumpfork/dominiontabs/issues/263

JanisBe avatar Oct 07 '20 22:10 JanisBe

Hey Sumpfork. I would like to assist you on this case. I saw that the translations for Menagerie are completely missing. That is why I created my own fork and a corresponding branch here.

I then added in the tests a small line to create the pdf file and to check if I am doing it correctly. However, for example the entry for "Black Cat", which I created here is not in the final pdf. I think the solution to the problem is easy. Can you give me a little hint? Then I will continue with the rest and also check/verify all other German translations.

alessandrofasse avatar Jan 19 '22 08:01 alessandrofasse

Hey Sumpfork. I would like to assist you on this case. I saw that the translations for Menagerie are completely missing. That is why I created my own fork and a corresponding branch here.

I then added in the tests a small line to create the pdf file and to check if I am doing it correctly. However, for example the entry for "Black Cat", which I created here is not in the final pdf. I think the solution to the problem is easy. Can you give me a little hint? Then I will continue with the rest and also check/verify all other German translations.

It looks to me like you didn't run doit update_languages as mentioned here. This produces the version of the card database that actually gets packaged with the python code. Wenn ich das mache kriege ich eine "Schwarze Katze" im PDF ohne Probleme.

sumpfork avatar Jan 22 '22 00:01 sumpfork

Many thanks for the help. I knew it was something simple that I overlooked :) Will continue with the rest and send a Pull Request :)

alessandrofasse avatar Jan 22 '22 06:01 alessandrofasse

Added a pull request: https://github.com/sumpfork/dominiontabs/pull/365

alessandrofasse avatar Jan 27 '22 20:01 alessandrofasse

Well, I already got all the texts for the German cards in my project but unfortunately in latex... But if it helps just copy whatever you need. My project is here: https://github.com/poet-of-the-fall/carddivider

poet-of-the-fall avatar Aug 27 '23 12:08 poet-of-the-fall