summernote icon indicating copy to clipboard operation
summernote copied to clipboard

Can you release v0.8.21?

Open wonsuc opened this issue 1 year ago • 17 comments
trafficstars

I mean it's been a so long while since the last version released. If v0.9.0 takes very very long times more, can you guys release the current develop branch with fixed hotfixes updates? Sorry if my opinion is not appropriate in the current situation of you guys.

wonsuc avatar Feb 20 '24 05:02 wonsuc

We're working on it. I can probably do it, but I'm not sure of the process that @lqez goes through, so unless I'm either given written or verbal permission to do so, I won't be doing it. I have been advocating for it though. If you don't require using Summernote via NPM or CDN, you can build the project locally if you require the latest changes.

DennisSuitters avatar Feb 20 '24 05:02 DennisSuitters

All libraries of our project need to be managed by npm, that's why.

wonsuc avatar Feb 20 '24 07:02 wonsuc

This blocks updating to 0.8.20 for me as well, the husky fix, PR #4365, is the main issue.

@lqez please help @DiemenDesign, or give permission :)

sebas-ambrero avatar Feb 22 '24 16:02 sebas-ambrero

Another vote for a patch release here. The husky issue that hasn't been released makes this library unusable if you don't use husky, since it can't be installed with out it

dqwork avatar Apr 04 '24 21:04 dqwork

It can, I don't use Husky, though, I do use it the Old Skool way which works fine for me.

I'll keep pushing for a release.

DennisSuitters avatar Apr 04 '24 22:04 DennisSuitters

I'm not sure what you mean by the old school way.

my package.json contains

"summernote": "^0.8.20",

I run npm ci and it fails with

npm ERR! path <redacted_path>\node_modules\summernote
npm ERR! command failed
npm ERR! command C:\WINDOWS\system32\cmd.exe /d /s /c husky install
npm ERR! 'husky' is not recognized as an internal or external command,
npm ERR! operable program or batch file.

If there is a different way to use this package that doesnt result in this failure (and doesn't require installing husky, please can you share it, it would be appreciated

dqwork avatar Apr 04 '24 22:04 dqwork

What I was referring to is the traditional way of incorporating Javascript into web pages using <script/> tags.

DennisSuitters avatar Apr 04 '24 23:04 DennisSuitters

ah I see, we bundle and pack and all that fun stuff via webpack so I don't thats an option for us, but good to know for others.

Anyway I look forward to the patch release (fingers crossed 😃 )

dqwork avatar Apr 05 '24 08:04 dqwork

Same, I was hoping it would have happened by now.

DennisSuitters avatar Apr 05 '24 09:04 DennisSuitters

Another vote to release version 0.8.21 with husky fix.

komatom avatar Apr 19 '24 10:04 komatom

Here is another vote to release a new version; I'm using this for a project I'm developing, and 0.8.20 has a broken Style button with Bootstrap 5. Would be great to rely on a CDN instead of having to vendor this in my code...

tsimonq2 avatar May 05 '24 22:05 tsimonq2

+1, would be nice to have a fresh version released :)

andrii-kasparevych avatar May 07 '24 15:05 andrii-kasparevych

I think @lqez is MIA (for months it looks like) and Dennis does not want to release without approval even though he could.

Not sure what the procedure is when @lqez does not return?

sebas-ambrero avatar May 08 '24 07:05 sebas-ambrero

I really do think there should be a release regardless of @lqez's return - they have not raised any objections, so perhaps their interest has moved on to something else. IMO there are more reasons to release than not release at this point, especially given the bitrot of the most current version.

@DennisSuitters would you reconsider, please?

tsimonq2 avatar May 16 '24 03:05 tsimonq2

Apologies for my super delayed response. I will review the recent updates today.

lqez avatar Jun 29 '24 02:06 lqez

@lqez: Just wanted to mention that your last commit 9651e6b65bbf579427a0767c682813ef1f950fa4 added the husky command in postinstall from #4365 again.

smoldaner avatar Jul 18 '24 08:07 smoldaner

any news on this? <3

benbender avatar Jul 24 '24 07:07 benbender