chromestore.js icon indicating copy to clipboard operation
chromestore.js copied to clipboard

Added typescript version

Open manfield opened this issue 9 years ago • 4 comments

We needed a typescript version of your library. If you like you may include in the main project.

manfield avatar Sep 15 '16 14:09 manfield

@manfield This is awesome šŸ˜„ . Out of curiosity, how are you using the library?

I think it would be best if you host this in your own repo (chromestore-typescript or something along those lines) and I link to it in the README. This way you'll be able to directly support your typescript version. I'm not actively working on this project, so I'm hesitant to merge in additional code that's not fixing bugs. Are you cool with this?

summera avatar Sep 26 '16 14:09 summera

Hi Ari, I use the library for a shoe catalog in a shop, on a ChromeBox platform instance.

Thank you for your feedback. I will follow your suggestion for the repo. I’m cool with that!

Sincerely Manfredi

Il giorno 26 set 2016, alle ore 16:40, Ari Summer [email protected] ha scritto:

@manfield https://github.com/manfield This is awesome šŸ˜„ . Out of curiosity, how are you using the library?

I think it would be best if you host this in your own repo and I link to it in the README. This way you'll be able to directly support your typescript version. I'm not actively working on this project, so I'm hesitant to merge in additional code that's not fixing bugs. Are you cool with this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/summera/chromestore.js/pull/8#issuecomment-249589526, or mute the thread https://github.com/notifications/unsubscribe-auth/AAYRZ5gP2ldI6AUwNqJ2uKYY-LjVZWbqks5qt9lUgaJpZM4J96zz.

manfield avatar Sep 26 '16 15:09 manfield

Perfect šŸ‘ . Let me know when the repo is up.

summera avatar Sep 26 '16 15:09 summera

Dear Ari, I thought, since the typescript file won't be included in the original distribution and since you're going to maintain the JS version only, that the best thing to do is to prepare a typescript definition file. It is a collection of interfaces, based on your classes, that permits to include your library in a typescript project. I think I will proceed this way.

Thanks! Manfredi

2016-09-26 17:56 GMT+02:00 Ari Summer [email protected]:

Perfect šŸ‘ . Let me know when the repo is up.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/summera/chromestore.js/pull/8#issuecomment-249612576, or mute the thread https://github.com/notifications/unsubscribe-auth/AAYRZ3MglbsMWCInqyUU427deEwG93LUks5qt-sQgaJpZM4J96zz .

Manfredi Petruso

[email protected]

FABVLA

Via Fontane, 93/d

31020 - Villorba (TV)

Questo messaggio e i suoi allegati sono indirizzati esclusivamente alle persone indicate. La diffusione, copia o qualsiasi altra azione derivante dalla conoscenza di queste informazioni sono rigorosamente vietate. Qualora abbiate ricevuto questo documento per errore siete cortesemente pregati di darne immediata comunicazione al mittente e di provvedere alla sua distruzione, Grazie.

This e-mail and any attachments is confidential and may contain privileged information intended for the addressee(s) only. Dissemination, copying, printing or use by anybody else is unauthorised. If you are not the intended recipient, please delete this message and any attachments and advise the sender by return e-mail, Thanks.

manfield avatar Sep 27 '16 09:09 manfield