vue-datepicker icon indicating copy to clipboard operation
vue-datepicker copied to clipboard

Upgrade to Vue 3

Open mst101 opened this issue 3 years ago • 1 comments

OK, this is as far as I've got with upgrading to Vue 3.

Everything is working fine in the browser, all e2e tests are passing and the build is ok. However, 6 unit tests are failing (see last commit). I would love to know why... Since when did element.focus() not focus an element?!

Any insight you may be able to provide most gratefully received...

PS. It still uses the Options API for now. The dependencies are up-to-date and have no vulnerabilities. I had trouble with getting the sidebar to work in vitepress, so tried vuepress 2 instead - see https://github.com/mst101/vue-datepicker/tree/feat/vue3-vuepress. That's all working, except for the Cleave & Vee-validate integrations which will need to be updated.

mst101 avatar Oct 19 '22 14:10 mst101

OK, so it turns out these tests were failing due to an issue with vue-test-utils. Upgrading from v2.1 to v 2.2 resolves the problem.

mst101 avatar Nov 01 '22 11:11 mst101

These tests are passing on the actions, is this ready now?

acallaghan avatar Jan 23 '23 10:01 acallaghan

Yes, as far as I am concerned... All that's remaining for the vue-3 version is to update the Cleave & Vee-validate integrations in the docs, as mentioned above. For now, I've simply left them out.

@MrWook - what needs to happen to get this off the ground?

mst101 avatar Jan 23 '23 11:01 mst101

can you also update the git repo about section, and mention it supports vue 3 now, and update the readme.md too

ankurk91 avatar May 10 '23 07:05 ankurk91

does version 5.0.0 support vue 3?

kalina559 avatar Jul 03 '23 13:07 kalina559

@kalina559 I don't think it does, I don't think the vue 3 version was released.

brandonburkett avatar Sep 07 '23 20:09 brandonburkett

@brandonburkett I've just emailed SumCumo to ask whether they have any interest in continuing with this project. Apparently they were taken over by another company not too long ago. I'll let you know if I hear anything...

mst101 avatar Sep 07 '23 21:09 mst101

@mst101 this is one of the last components of our vue3 conversion project. I may have to switch to vue flat date picker or similar.

I saw you had a fork, is it possible to release the vue3 version off your fork?

brandonburkett avatar Sep 07 '23 21:09 brandonburkett

That's not something I've done before, so I'm not sure how much work that would involve. I've just started a new job and don't have a huge amount of time at the moment, so I'd really prefer it if someone else could handle that side of things. Let's see if I hear back from SumCumo. Failing that, I'll have a look into releasing my fork.

mst101 avatar Sep 07 '23 21:09 mst101