Questions about whether the with_capacity method of the Block interface is valid

[monadbobo]

I read the code of clickhouse-rs and found that after setting the capacity in Block::with_capacity, the later code does not use it. Shouldn't this be changed here?

    /// Constructs a new, empty `Block` with the specified capacity.
    pub fn with_capacity(capacity: usize) -> Self {
        Self {
            info: Default::default(),
            columns: Vec::with_capacity(capacity),
            capacity
        }
    }

[suharev7]

The size field stores the estimated number of rows, not columns. This is reasonable because, in practice, the number of rows in blocks is usually much larger than the number of columns, and reducing unnecessary allocations when adding rows can significantly improve performance. These are the places where this field is used:

• data: <dyn ColumnData>::from_type::<ArcColumnWrapper>(sql_type, timezone, block.capacity)?
• .push(vec![0_u8; max(self.capacity * AVG_STR_SIZE, size)]);

[monadbobo]

Thank you very much for your answer.