Lily Skye

Results 115 comments of Lily Skye

Is there any risk to the sandboxing added other than "if someone messes with these objects directly, it will affect other tests"? Or is there something inherent in the way...

What if jest transformed `instanceof Array` and `instanceof Error` *specifically* into something like `instanceof jest.__parentContextArray` and `instanceof jest.__parentContextError`?

We could override `Symbol.hasInstance` on the globals in the child context to also check their parent context if the first check fails... But `Symbol.hasInstance` only works in node 6.10.0+ or...

Assuming performance seems fine, which globals should it be applied to? `Error` and `Array`... `Buffer` maybe, too?

I may be able to tackle a PR for this this weekend. I'm assuming we want it in both the node and jsdom environments?

I've started work on this in https://github.com/suchipi/jest/tree/instanceof_overrides, but am having difficulty reproducing the original issue. @PlasmaPower or @thomashuston do you have a minimal repro I could test against?

I haven't looked at it in ages, but I still have a branch somewhere. I might be able to take a look this weekend.

I set it to 2 but I have the same issue. I also tried setting it to 1 and it seems maybe a little bit better but still not usable.

For readers who may be arriving from search engines: as noted in [the Steam Deck FAQ](https://goatcorp.github.io/faq/steamdeck), you can set the environment variable `XL_SECRET_PROVIDER` to `FILE` to persist your password to...