Chris Grigg

Results 97 comments of Chris Grigg

Not at all. It might be a little tricky, I might be able to poke at it tomorrow. Not even sure how necessary it is or if it will be...

Really nice! This didn't run on Travis for some reason. Could you push something (anything) to your branch to see if it'll submit now?

Ah, right. I'm a little spoiled by pushing directly to branches on this repo, where it will always run at least one set of tests on Travis. :-) Can you...

It was meant to be removed, I don't think it's a useful set of tests because of the intense amount of stubbing going on, it's too tied to implementation. I...

Something to watch out for is `tx = Neo4j::Transaction.new`. Right now, the expectation is that `tx` would be the only transaction object, so you can do `tx.failed?` or `tx.expired?`. If...

`./spec/neo4j-server/rest/create_node_spec.rb` can be deleted or rewritten. I don't know why it's using HTTParty directly. I'm not sure what it's trying to demonstrate that isn't already proven elsewhere.

Make sure you run the neo4j gem's master branch tests using your branch of core, too. It does a lot of transaction tests. That `tx = Neo4j::Transaction.new` thing is gonna...

I keep running into cases where I want to use the presence or lack of query clauses and values to modify a query in some way. "If the query contains...

Yes, I did exactly this while implementing "limit_value" in the other gem yesterday. On Wednesday, May 6, 2015, Brian Underwood [email protected] wrote: > Do you have a specific use case?...

"limit_value" is an ActiveRecord thing that a gem I'm porting over needed. Within the same gem, I had to figure out if "order" had been called and then, if so,...