sublime_merge icon indicating copy to clipboard operation
sublime_merge copied to clipboard

Tab restore order is wild

Open themilkman opened this issue 1 year ago • 5 comments

Version info

  • OS: Kubuntu 23.10
  • Build: 2092

Description

Restoring closed tabs does not restore them in the inverse order.

Steps to reproduce

tab order: X A Y B C D

closing: A B D C

restore order by SM: A C B

tab order after restore: X Y A C B

Expected behavior

Restoring C, D, B, A

(beside the core issue, is is there a way to configure a higher amounts of tabs to restore than only 3 ?)

themilkman avatar Mar 14 '24 10:03 themilkman

  • OS: Manjaro Gnome 23.1.3
  • Build: 2092

This issue is happening to me as well.

ipmanlk avatar Mar 15 '24 04:03 ipmanlk

G'day everyone,

Thank you for reporting this issue! I've got a fix for this in the works and will give you an update again once things have progressed.

Cheers, - Dylan from Sublime HQ

dpjohnst avatar Mar 27 '24 02:03 dpjohnst

Thanks for the update, Dylan!

Will the amount of tabs to restore also get increased?

themilkman avatar Mar 27 '24 08:03 themilkman

Hi @themilkman,

The maximum amount of tabs to restore is currently set at 128 tabs. I believe the behavior you're referencing might have been caused by the bug I've just fixed.

Could you confirm if any of the repositories you're seeing this issue with have worktrees enabled?

Cheers, - Dylan from Sublime HQ

dpjohnst avatar Mar 27 '24 23:03 dpjohnst

Hi @dpjohnst, I can confirm that at least some of my repos I used for this issue's setup have worktrees enabled.

I just tried it again with a set of repos that don't: The tab restore order is still wrong, but I could indeed restore more/all tabs. So that seems to be related, yes :-)

Cheers!

themilkman avatar Mar 28 '24 07:03 themilkman

Cannot reproduce anymore, seems fixed as of Build 2093 according to changelog.

themilkman avatar Aug 13 '24 06:08 themilkman