Brandon Davis comments

Results 229 comments of


                                            Brandon Davis

trafficstars

Don't try to set cookie from hash during OAuth login

I endorse removing it from girderRest, but I still think we ought to provide it as a utility. I don't know that we have enough recipes to warrant a cookbook,...

Enable capture and custom content handling of empty search results and search error

@mgrauer this looks like something you're still going to want. Is that correct?

Way to disable girderToken in hash on oauth callback?

Where should it go instead? > Ideally I'd like a way (maybe it should be the default?) to not append a hash string at all. I don't think I'm following....

Way to disable girderToken in hash on oauth callback?

Are we talking about the situation where the GWC app is served from the same origin as girder such that it has access to the cookies set by girder and...

Way to disable girderToken in hash on oauth callback?

https://github.com/girder/girder_web_components/pull/189 is one possible solution. There are others.

Document job event binding and output reference kwargs.

> I assume we want to pass some small information to the endpoint, such as the job's completion status and the job ID, but not large data, like an output...

Document job event binding and output reference kwargs.

> Maybe you already knew about that and were making a case that the webhook approach is superior. No, I didn't know this was possible. It would be great to...

Document job event binding and output reference kwargs.

Converting this issue to a docs update issue. I'll make a PR sometime after I've used it a bit more.

Dark mode for search bar

Light search results in a `v-menu` under a dark search bar will look weird, so that would need to be dark too. Before taking on this work, I'd like to...

Have some process for auto-generating documentation

Worth looking into again, maybe.