stuartmorgan-g

Results 1282 comments of stuartmorgan-g

> 1. Should the `IOSAuthMessages` be renamed as `DarwinAuthMessages` to be used commonly for `authMessages` param in `LocalAuthentication.authenticate`. No; there is no reason to expect that strings would be the...

> @stuartmorgan can you tell me what is exactly failing and how to solve it. The project's unit tests appear to be configured incorrectly; I'll take a look in Xcode....

The unit test file had not been added to the macOS project, so it couldn't build anything. I've pushed a fix.

FYI, you'll need to resolve a raft of conflicts with https://github.com/flutter/packages/pull/6108 once that lands. The easiest way to do it will most likely be to make the same changes in...

Since this is marked as a draft and hasn't been updated in several months I'm going to close it to clean out our review queue. Please don't hesitate to submit...

@mike-v2 I see there are new commits here since my review; is this ready for re-review?

Thank you for your contribution. I'm going to close this PR for now since there are outstanding comments, just to get this off our PR review queue. Please don't hesitate...

> [x] I listed at least one issue that this PR fixes in the description above. @matheuslutero Could you file a proposal issue with a more detailed use case, to...

> I will attach an example of this usage here. Please file a proposal issue, as requested above and described [here](https://github.com/flutter/flutter/wiki/Tree-hygiene#overview), rather that making the proposal in the PR.

@matheuslutero Is the proposal discussed above still something you are planning on moving forward with? Marking as a draft for now since there's not yet sufficient context for a code...