stuartmorgan-g

Results 1282 comments of stuartmorgan-g

I played with the latest version locally a bit, and I can confirm that those assertions are gone for me! A few things I noticed: - Playback seems intermittently choppy....

> * I'm getting logging from the engine about an event being sent from a non-platform thread. I'm going to see if I can quickly track that down. Looks like...

> * Resizing the window pretty reliably crashes Running this under the debugger, in one case I saw an assertion failure in `MediaEngineWrapper::EnsureTextureCreated`; as with the earlier crash, it's `texture_.put()`...

> This solved these issues, but I think other plugins might benefit from this, as there is an equivalent in Android and iOS. https://github.com/flutter/flutter/issues/134346 has some related discussion; we've considered,...

@FZY456 You've only included the stack there, not the actual error.

From triage: What's the current status of this PR? Is it just waiting for an updated review?

From triage: ping @dnfield on this review

Per the comment in https://github.com/flutter/flutter/issues/140685, the first step here would need to be a package rename; we wouldn't accept this as-is since it duplicates a significant amount of code. Marking...

> `local_auth_foundation` as in examples you gave or `local_auth_darwin`? `LocalAuthentication` is not from the Foundation framework, so we would not call it `local_auth_foundation`.

> > Examples: [flutter/plugins#6988](https://github.com/flutter/plugins/pull/6988) [flutter/plugins#6920](https://github.com/flutter/plugins/pull/6920) > > Aahhh, now I get it. Note that those are a single PR for each plugin because we were merging existing implementations for two...