stuartmorgan-g

Results 1282 comments of stuartmorgan-g

Please see https://github.com/flutter/flutter/wiki/Tree-hygiene#tldr for expected review times. It's been less than a full business day since you posted the last version.

Is this ready for re-review? There are still unaddressed comments and failing tests, so I assumed it was a work-in-progress.

> I am not seeing a clean way to use the Platform.isMacos and still have the dart test cases pass. Per my earlier comment, you can wrap those calls in...

@alexrabin-sentracam I'll re-review when I have time (I currently have some very high priority work that will delay it); it's not necessary to constantly merge the branch in the meantime.

> * [x] I [linked to at least one issue that this PR fixes](https://github.com/flutter/flutter/wiki/Tree-hygiene#overview) in the description above. I'm not seeing a linked issue. This should have one, because there...

> When I searched, I didn't find this issue in Flutter's issues. Please see step 2 [here](https://github.com/flutter/flutter/wiki/Tree-hygiene#overview). > I would appreciate it if you could tag individuals from the Android...

Marking as a draft pending an issue being filed for discussion, and a resolution there.

Since this is marked as a draft and hasn't been updated in several months I'm going to close it to clean out our review queue. Please don't hesitate to submit...

Thanks for the contribution, but this goes into a lot of details we wouldn't want to add to the README. E.g., explaining concepts like bundle IDs or the mechanics of...

> I think the docs should tell something about the correct usage. We agree, which is why https://github.com/flutter/flutter/issues/36673 is open. I'd be happy to review a PR along the lines...