stuartmorgan-g

Results 1282 comments of stuartmorgan-g

> I was having trouble getting the changelog command working throwing > > ``` > ProcessException: fatal: Not a valid object name upstream\main > Command: git merge-base upstream\main HEAD >...

> but this is known to be a correct identifer tested on XCode 15 Our CI currently uses Xcode 14; updating is still an ongoing project.

Landing it is blocked on https://github.com/flutter/flutter/issues/132237, but it can be reviewed in the meantime.

> @stuartmorgan does your comment from the other PR ([#5957 (comment)](https://github.com/flutter/packages/pull/5957#issuecomment-1906818335)) also apply to this PR? In theory yes; I realized after writing that though that this specific case is...

> So I'll file an issue about the need to add API to get notifications about camera availability changes https://github.com/flutter/flutter/issues/142239

Since this is marked as a draft and hasn't been updated in several months I'm going to close it to clean out our review queue. Please don't hesitate to submit...

In general I think we should use our newer patterns when possible, and since this case is extremely niche I would definitely prefer not to expand the cross-platform API surface....

> I think it's fine to add custom Android options to VideoPlayerOptions, especially since it already includes webOptions. Already having some code that uses a pattern that we've found doesn't...

Closing for now, per the comment above, in favor of discussion in https://github.com/flutter/packages/pull/5900.