stuartmorgan-g
stuartmorgan-g
I've enabled a bunch of tests. Disabled still are: - The all-type class object tests, which hang (at least some; I haven't tried each one individually yet). - The Flutter...
I put the code from `Arguments of multiple types serialize and deserialize correctly` into `example_app.dart` to play with it, and the app to make sure I could repro before I...
(Also, the PR will need to be updated when https://github.com/flutter/packages/pull/6600 lands since it changes the way enums and classes are serialized.)
Thanks for the submission! In the future, please do not delete the checklist that is in the PR template; it is there for a reason. This PR is missing required...
Sorry about that, I didn't realize I never published those comments 🙁
Thank you for your contribution. I'm going to close this PR for now since there are outstanding comments, just to get this off our PR review queue. Please don't hesitate...
@foxtrotravi Are you still planning on updating this PR to address the review comments above?
Thank you for your contribution. I'm going to close this PR for now since there are outstanding comments, just to get this off our PR review queue. Please don't hesitate...
It's not at all clear to me that adding logical and ephemeral camera types to the discovery process without any changes to the higher-level camera API is a good idea....
Marking as a draft pending a design proposal, per comments above. @rickcasson Is that something you are planning on moving forward with?