Stuart Marks

Sorry, this got derailed by the discussion of `SequencedCollection::replaceAll`. I think we should just set that issue aside. I don't think `SequencedCollection::replaceAll` makes sense, thus this PR shouldn't be held...

@amaembo a couple comments on the test. The test should probably have `@key randomness` added to it. On 2022-10-28, @bplb wrote: > jdk.test.lib.RandomFactory can be used to generate a reproducible...

Thanks for updates. I've tweaked the CSR a bit and I've marked it reviewed; please go ahead and move it to Finalized. (On rebase vs. merge, merge is definitely preferable....

The CSR still needs to be Approved. (Yes, unfortunately, Finalized is not a terminal state. It means the _writing of the proposal_ has been finalized and is ready to be...

The current state of the `removeExtension` code drops the parent part of the path if there is no extension or if there is an empty extension (i.e., trailing dot): jshell>...

Hm, I don't think we want to add any synchronized blocks within a shutdown hook. If a thread is blocked reading from the console, it will hold readLock; if the...

I think we're assuming here that it's good practice for the Console to snapshot the initial tty state and to restore that state on exit. That's probably right. If we're...

Ah, ok, so each provider has its own shutdown hook, so it's never the case that both hooks are installed at the same time and can conflict with each other....

OK, I went over all this again, and it looks pretty good, though there's a potential risk. In the old code, the `restoreEcho` variable was usually false, and it was...

Latest changes look good.