ecs-autoscale icon indicating copy to clipboard operation
ecs-autoscale copied to clipboard

Published 20 hours ago • verified publisher icon structurely

issue-34: add replace_empty_with_zero parameter for Cloudwatch metrics

Open Mortinke opened this issue 6 years ago • 3 comments

Mortinke avatar Sep 30 '19 10:09 Mortinke

@Mortinke thanks for this! This looks like a reasonable solution. I'm wondering though if it would be better to make it more general and have something like a default parameter instead of the replace_empty_with_zeros parameter.

epwalsh avatar Sep 30 '19 16:09 epwalsh

@epwalsh: sorry, I missed your comment. I am on vacation with bad internet connection until 01.11. Then I'll take a look at it again.

Mortinke avatar Oct 08 '19 08:10 Mortinke

@epwalsh: Unfortunately I didn't make it earlier - other priorities in other projects :( Can you look over the PR again? Thanks!

Mortinke avatar May 11 '20 13:05 Mortinke