stripe-dotnet
stripe-dotnet copied to clipboard
Support JSON serialization with System.Text.Json
Fixes #2495
Add support for JSON serialization with System.Text.Json.
- Add
JsonSerializerinterface and implementNewtonsoftJsonSerializerandSystemTextJsonSerializerclasses insrc/Stripe.net/Infrastructure/JsonSerializer.cs. - Update
StripeEntityclass insrc/Stripe.net/Entities/_base/StripeEntity.csto use theJsonSerializerinterface forToJsonandFromJsonmethods. - Replace
Newtonsoft.Jsonattributes withSystem.Text.Jsonattributes insrc/Stripe.net/Entities/Customers/Customer.cs,src/Stripe.net/Entities/_common/Address.cs,src/Stripe.net/Entities/_common/AddressJapan.cs,src/Stripe.net/Entities/_common/Shipping.cs,src/Stripe.net/Entities/AccountLinks/AccountLink.cs, andsrc/Stripe.net/Entities/Accounts/Account.cs. - Add conditional compilation to use appropriate attributes based on the selected JSON serializer in the above files.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
@hootanht Thank you submitting this PR! Supporting System.Text.Json as an alternative to Newtonsoft is on our to-do list for this quarter, and I'd love to work with you on getting this landed. We have a code generator that is responsible for generating some 500-odd files that I definitely don't want to ask you to manually update, and I want to be able to include this in such a way that one SDK will be compatible with users of both Newtonsoft and System.Text.Json. Let me review your changes and see how we can incorporate them into our code generation infrastructure, make sure it won't break existing users, and then I'll plan to push updates right back to this branch/PR. Sound good?
@hootanht Thank you submitting this PR! Supporting System.Text.Json as an alternative to Newtonsoft is on our to-do list for this quarter, and I'd love to work with you on getting this landed. We have a code generator that is responsible for generating some 500-odd files that I definitely don't want to ask you to manually update, and I want to be able to include this in such a way that one SDK will be compatible with users of both Newtonsoft and System.Text.Json. Let me review your changes and see how we can incorporate them into our code generation infrastructure, make sure it won't break existing users, and then I'll plan to push updates right back to this branch/PR. Sound good?
Awesome 👌
Hi @hootanht ! Just a quick update here; I'm actually considering a more pared down approach here, to reduce the blast zone of a change while still solving the original ticket. I left a comment over on the issue: https://github.com/stripe/stripe-dotnet/issues/2495#issuecomment-2468667732, mind giving it a read and chiming in there? Thanks!
Thanks a lot
Sure thing! And if that doesn't completely work for your use case we can definitely revisit this here. Thanks again!