strawberry icon indicating copy to clipboard operation
strawberry copied to clipboard

Django AsyncGraphQLView param: subscriptions_enabled misleading

Open nrbnlulu opened this issue 3 years ago • 1 comments
trafficstars

The docs about subscriptions_enabled are misleading.

the docs says:

subscriptions_enabled: optional boolean parameter enabling subscriptions in the GraphiQL interface, defaults to False.

I as a new user couldn't understand that It is just some hack to satisfy GraphiQL and not at all supporting websockets... especially because Django can handle only HTTP requests and not websockets.

I realized that only after digging threw the source code and #726 , #1215 , #344.

I would remove that and I think what @patrick91 suggested in #726 :

Or we should tell people to use the ASGI view even for non websockets GraphQL :)

Is a better solution.

nrbnlulu avatar Jul 28 '22 23:07 nrbnlulu

yes, we should change that 😊 feel free to make a PR!

patrick91 avatar Jul 29 '22 10:07 patrick91