strapi
strapi copied to clipboard
fix(admin): check clone with isAxiosError in CM ListView
trafficstars
Clone feature did not work in ListView, did some debugging, and for some reason, err instanceof AxiosError did not work when cloning entities. (probably related to multiple loaded axios instances)
Using the native axios util to check if is an Axios error worked.
Using this patch, meanwhile.
patches/@strapi+admin+4.24.2.patch
diff --git a/node_modules/@strapi/admin/dist/_chunks/index-KTSQuD27.mjs b/node_modules/@strapi/admin/dist/_chunks/index-KTSQuD27.mjs
index b8e77b7..ef64869 100644
--- a/node_modules/@strapi/admin/dist/_chunks/index-KTSQuD27.mjs
+++ b/node_modules/@strapi/admin/dist/_chunks/index-KTSQuD27.mjs
@@ -17825,7 +17825,7 @@ const ListViewPage = ({
});
}
} catch (err) {
- if (err instanceof AxiosError) {
+ if (isAxiosError(err)) {
const { prohibitedFields } = err.response?.data.error.details;
setClonedEntryId(id);
setProhibitedCloningFields(prohibitedFields);
diff --git a/node_modules/@strapi/admin/dist/_chunks/index-hDD1JNph.js b/node_modules/@strapi/admin/dist/_chunks/index-hDD1JNph.js
index bf8d208..20d40e5 100644
--- a/node_modules/@strapi/admin/dist/_chunks/index-hDD1JNph.js
+++ b/node_modules/@strapi/admin/dist/_chunks/index-hDD1JNph.js
@@ -17886,7 +17886,7 @@ const ListViewPage = ({
});
}
} catch (err) {
- if (err instanceof axios.AxiosError) {
+ if (axios.isAxiosError(err)) {
const { prohibitedFields } = err.response?.data.error.details;
setClonedEntryId(id);
setProhibitedCloningFields(prohibitedFields);
PS: It seems there are a lot of err instanceof AxiosError across the project.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| contributor-docs | ❌ Failed (Inspect) | May 17, 2024 11:57am |
Is anyone available to look into this PR?
cc @alexandrebodin