Jack Grigg

Results 961 comments of Jack Grigg

In the `age` library crate, that is indeed what we already do. However, in `rage` if both the input and output come from a TTY, we buffer the entire output...

> For example, there is an iso file of 4GB named **a.iso** and I want to encrypt it to **a.o**, so I use the following command in windows command prompt:...

> I was a little bit alarmed about the name `UnauthorizedTransactionDataWithSaplingProofs` (i.e. why so unorthogonal?), but then I saw the motivation and it's fine. My hope is that this type...

In e3a29b86cd473324b3a8bd480e6640b6fac03d84 I've added Yet Another Intermediate Trait `Bundles`, which I think solves the "conditional compilation of bundles" that is necessary for merging code that is not currently part of...

[Force-pushed](https://github.com/zcash/librustzcash/compare/e3a29b86cd473324b3a8bd480e6640b6fac03d84..d185e6fd592a8541989a018ddd8772dff1099fad) to merge the commit introducing the `Bundles` trait back into the rest of the commits, simplifying them.

[Force-pushed](https://github.com/zcash/librustzcash/compare/d185e6fd592a8541989a018ddd8772dff1099fad..65df348cf11b83815134d10194f3055de7212ed0) to address some initial review comments from a pairing with @nuttycom.

[Force-pushed](https://github.com/zcash/librustzcash/compare/65df348cf11b83815134d10194f3055de7212ed0..6da0ba6b072273333daaacf3fdfd685b9425dae9) to move Sprout onto the `Bundles` trait. It has no authorization traits because we only support already-authorized Sprout bundles (due to not supporting Sprout in transaction building).

[Force-pushed](https://github.com/zcash/librustzcash/compare/6da0ba6b072273333daaacf3fdfd685b9425dae9..443855e9e9821e43dc9d937cc1516769d73fc675) to move TZEs onto the `Bundles` trait, as a proof-of-concept for other conditionally-compiled transaction format changes that we want to merge into the codebase before inclusion in consensus (e.g....

[Force-pushed](https://github.com/zcash/librustzcash/compare/443855e9e9821e43dc9d937cc1516769d73fc675..47189947d2b57a8ca72e2beaf0d4c104c45adc19) to adjust how the new traits work in order to eliminate the bounds on the protocol-crate-specific authorization traits.

[Force-pushed](https://github.com/zcash/librustzcash/compare/47189947d2b57a8ca72e2beaf0d4c104c45adc19..7477ff1604afded995f66a5709892a77885d822d) with some further decoupling adjustments and trait renames. It also removes the `NoTransparent` etc. changes (and the `TransactionWith` refactor) as not currently necessary, because the dependency removal will be...