Jack Grigg

I've switched to using the nested closures approach, and it's still significantly slower. Next step would be to look at the assembly changes between #415 and this PR, to figure...

I strongly disagree with exposing `from_coordinates_unchecked` on principle; it's dangerous for security. If unchecked construction is to be permitted, I think it should only be from byte encodings (which are...

_Checked_ construction is a more reasonable thing to expose in a public API. I still dislike it, and would prefer it be segmented in some way so downstream users only...

A disabled-by-default feature flag is probably the right way to handle this, along with clear documentation. Another possibility might be to have `trait DecryptionPrimitive` in an underlying `rsa-core` crate that...

So, was there a preference between exposing `DecryptionPrimitive` and `EncryptionPrimitive` via a default-off feature flag, or by moving `DecryptionPrimitive` and `EncryptionPrimitive` into an `rsa-core` crate? That seems to be the...

Let's take `chacha20poly1305` in its current form and look at the AVX2 hot path (ignoring all the autodetect code in `chacha20` and `poly1305`). `chacha20poly1305::cipher`: ```rust impl Cipher where C: StreamCipher...

> So, perhaps the API would be simpler if, rather than being conceptualized as a new triple-base scalar multiplication, it was conceptualized as a more efficient implementation of the check:...

I've reworked the PR following @hdevalence's comments, and added an AVX2 backend. `abglsv_pornin::mul` is passing the fixed test case for both serial and AVX2, but is occasionally failing the random...

Force-pushed to fix the serial and vector Straus impls, which were [not correctly checking for the first non-zero `d_1` bit](https://github.com/dalek-cryptography/curve25519-dalek/compare/b401033ea0836a8843ea3fe394079876c94fb71e..2194715ad91be24225432496a242e414665e1a57). The tests now pass.

> ### Handling advice column assignment in wrong phase > > Instead of returning an error, currently `WitnessCollection` ignores the advice column assignment if phase doesn't match (like [this](https://github.com/zcash/halo2/blob/a330f520086e204f9ca2dfef0ec46802a2003f82/halo2_proofs/src/plonk/prover.rs#L195-L198)). The...