Jack Grigg
Jack Grigg
Two things: - This is going to cause merge conflicts with #203, so once that is ready and merged I can rework this PR. - Once #203 is merged this...
I don't personally have an opinion. I've never used any JavaScript plotting libraries prior to setting codespeed up; since then I have now used jqPlot and d3, but only just...
Sorry for the delay, work's been keeping me busy. I'll do this Friday :smile:
Sorry for dropping the ball on this! I'll be doing some more codespeed work in the next few weeks, so I'll get this integrated while I do :)
Rebased on 0.11.0 (because that's what I've been working from locally), and fortunately there are no merge conflicts with master!
Rebased on master, still appears to work for me!
That padding change appears to be left over from the original PR #113 (see e.g. https://github.com/tobami/codespeed/pull/113#issuecomment-4681936). I can try playing around with the contents, but not being the original author...
Here are the properties I'd like to see in this setup: - A Benchmark may have zero or more Parameters. - A Result must specify a value for each Parameter...
I'm going to proceed with implementing this using a ParameterValue model, given that the upsides to the other approach are minimal.
The scaling of the rendered image is currently off; the graph and axis labels are rendered larger than the axes and tick labels, causing the graph to appear truncated.