Martin Šťovíček
Martin Šťovíček
Hey @mtumiati. Thanks for the PR! Do you think we need to add any new tests for this? The current tests are passing, but I'm wondering if the expected results...
I'd like to have a test for this before merging.
@Soreine Are you integrating React Native into an existing iOS project, or is it a fresh project bootstrapped with the React Native CLI?
So how do you go about versioning with env vars in conjunction with RNV? Is it a separate process from when RNV does its versioning? Are those variables defined at...
I'll have to check what happens when you init a new RN app nowadays (and update our test fixtures) because AFAIK `$(CURRENT_PROJECT_VERSION)` was always used in plists. Now that we...
I wouldn't recommend doing things manually in Xcode - especially versioning, when already using RNV. Of course there will be things that need to be done, but I would then...
Just did a fresh `npx react-native init AwesomeProject` and it looks like the stock plist files have hardcoded values for both `CFBundleShortVersionString` and `CFBundleVersion`. I guess we could still merge...
How are you executing `react-native-version`? Is it installed globally, or are you running it from the project? Furthermore, can you provide a sample or an idea of your project directory...
I guess we could change this condition to always test both properties after converting them `.toLowerCase()`. Do you want to make a PR?
Looks good. I'll check it out later today. Could you cherry-pick 9801fba into your other branch (iltumio:issue-161) with the earlier PR (#162) and close this one? Thanks.