multicluster-observability-operator
multicluster-observability-operator copied to clipboard
stolostron
Update alerts federation
Do not Federate PodDisruptionBudgetAtLimit when poddisruptionbudget=~"kubevirt-disruption-budget-.*"
These alerts are silenced on the clusters by default and should not be federated.
Signed-off-by: Shirly Radco [email protected]
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: sradco Once this PR has been reviewed and has the lgtm label, please assign marcolan018 for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@sradco: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-kind | 728ecea4e4562badceab2574866bbbb8151380df | link | true | /test e2e-kind |
| ci/prow/test-e2e | 728ecea4e4562badceab2574866bbbb8151380df | link | true | /test test-e2e |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
Note, as we discussed, in slack, this won't really solve the customers problem, since their problem was with alertmanager, and this will only change what is shown in the Grafana dashboards. I do not think we should merge this, at least not if it's not specifically requested.
